Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acoustics module updates #359

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

jmcvey3
Copy link
Contributor

@jmcvey3 jmcvey3 commented Nov 14, 2024

Some of the code updates that got lost in translation when pulling the previous PR together. The larger updates are in the example jupyter notebook, where I added some sections with the band_aggregate method and did some editing/clarification.

@jmcvey3 jmcvey3 requested a review from ssolson November 14, 2024 22:57
@ssolson ssolson added the Clean Up Improve code consistency and readability label Nov 15, 2024
Copy link
Contributor

@ssolson ssolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Overall minor changes to acoustics module code with improvements to example notebook.

@jmcvey3 jmcvey3 merged commit 9c74040 into MHKiT-Software:develop Nov 15, 2024
42 checks passed
@jmcvey3 jmcvey3 deleted the acoustics-updates branch November 15, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Up Improve code consistency and readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants