Skip to content

MITRE Engage Galaxy created #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

MITRE Engage Galaxy created #1013

merged 1 commit into from
Jul 10, 2025

Conversation

th3r3d
Copy link
Contributor

@th3r3d th3r3d commented Aug 20, 2024

I tried my best to create MISP Galaxy for MITRE Engage. More can be seen at https://engage.mitre.org

@cvandeplas
Copy link
Member

Thank you very much @th3r3d .
It looks like there is still an issue. The tests complain about parse error: Expected separator between values at line 4, column 16
It looks like a comma is missing at line 3.

Can you have a quick look and fix it?

Before running, please run the ./jq_all_the_things.sh and ./validate_all.sh.

Also make sure to re-generate the readme: update_README_with_index.py.

Lastly, would you be open to also share the script you used to generate this galaxy?
This should allow us to re-generate it in the future whenever there are updates in MITRE Engage.

If all works well with above scripts, tests should run fine.
All the best !

@th3r3d
Copy link
Contributor Author

th3r3d commented Aug 20, 2024

I did all script checks, but Im not able to do update README. You were right on line 3 was missing comma. I will try later on linux machine, it maybe some mac thing.
Script is here, but little bit messy (you need engage xlxs from : Download): https://github.com/th3r3d/scripts/blob/main/Python/engage-2-MISP.py

@th3r3d
Copy link
Contributor Author

th3r3d commented Aug 20, 2024

I did came through all checks (fix few more typos and unsupported values) and get OK message with, but Im not able to run update README script.

@th3r3d
Copy link
Contributor Author

th3r3d commented Aug 20, 2024

All right finally - all done now. Thanks for patience

@adulau
Copy link
Member

adulau commented Sep 19, 2024

@th3r3d Can you review the PR to make the test pass? Thanks a lot.

Copy link
Contributor Author

@th3r3d th3r3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed README for Engage

@adulau
Copy link
Member

adulau commented Sep 19, 2024

ERROR: Please commit your changes, and make sure you run ./jq_all_the_things.sh before committing. ;-)

@adulau
Copy link
Member

adulau commented Oct 15, 2024

I see some files from your Python env in this pull-request ;-) Can you remove all those files? or do another PR?

@th3r3d
Copy link
Contributor Author

th3r3d commented Oct 30, 2024

Will do new PR

@th3r3d
Copy link
Contributor Author

th3r3d commented Oct 30, 2024

Done

@adulau
Copy link
Member

adulau commented Jan 24, 2025

Thank you. Can you remove the files which are not related https://github.com/MISP/misp-galaxy/pull/1013/files ? or do a clean pull-request. I really would like to merge it.

@th3r3d
Copy link
Contributor Author

th3r3d commented Jan 27, 2025

Hope, I finally got it work

Snímek obrazovky 2025-01-27 v 17 45 27

@adulau
Copy link
Member

adulau commented Jun 30, 2025

Any news for the updated PR? Thanks a lot.

@th3r3d
Copy link
Contributor Author

th3r3d commented Jul 3, 2025

I'll do new PR on weekend together with ADS object update.

@adulau adulau merged commit 731ab6d into MISP:main Jul 10, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants