Allow for n distortion params #93
Open
+494
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ToniRV Is this ready to pull? |
|
Ready yes! Let me know how it goes! |
|
@ToniRV When I build it with current Kimera-VIO-ROS master , I get the following error: Do you have a pair of Kimera-VIO and Kimera-VIO-ROS branches that compile here? |
|
It looks like Kimera-VIO-ROS has a stubbed method for mapping coefficients to gtsam calibration functions. Because the calibration_ field appears to have been removed in the refactor, I assume this stubbed method is no longer necessary-- I'm going to remove it and see if it compiles. |
|
Fixed Kimera-VIO-ROS branch fix/distortion. It compiles-- going to test the five-parameter distortion models now. |
…a-VIO into fix/distortion * 'feature/euroc_playground' of github.mit.edu:SPARK/Kimera-VIO: Fix sensor name Disable testEurocPlayground for now, needs dataset Add display flag to tests Do not display when running tests Wrap-up with camera, stereo_camera, and undistortrectifier Store depth maps Add mono camera, not tested Minor rename in euroc dataprov Fix pipeline: kalpha in stereo set to -1 Avoid unecessary math for baseline.. Fix errors from merge, update to OpenCvDisplay and Viz HUGE Commit: something broke for pipeline, add euroc playground stereo recons Add projection in stereo camera Remove unneeded statics in euroc play Finally got imgs in EurocPlayground right HUGE: fix opencv viz bug, improve euroc playground Add EurocPlayground
v-lopez
reviewed
Feb 18, 2021
Comment on lines
+95
to
+96
| cv::Mat | ||
| ; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.