Skip to content

renames 10s game_delay_multiplier #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2025

Conversation

tracerrx
Copy link
Contributor

Rename preferred_game_update_delay_in_10s_of_seconds to game_delay_multiplier throughout in order to add sanity to previous PR which moves api_refresh_rate top config.

@WardBrian
Copy link
Member

I realize I'm responsible for the original sin here, but I don't love game_delay_multiplier either. I think it's important to keep in the fact that this only really affects your preferred game. multiplier is fine, but "of what" seems like a valid question a user might ask

preferred_game_refresh_lag?

@tracerrx
Copy link
Contributor Author

I'm not in love with the name either, I submitted as a separate PR to make it relatively easy to change again... but preferred_game_refresh_lag_multiplier is almost as bad as 10's of seconds IMHO...

preferred_game_delay_multiplier ??

@WardBrian
Copy link
Member

preferred_game_delay_multiplier

👍🏻

@ty-porter ty-porter merged commit f76e852 into MLB-LED-Scoreboard:dev Jun 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants