Fix the q2 diagnostics in NoahMP #1341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm that this is a bug and the fix here looks good. This PR for the bug fix needs to be included as soon as possible. This grid-mean Q2 diagnostic calculation is not in the community Noah-MP code version, but added during the Noah-MP coupling with MPAS. This is why we did not notice this in other Noah-MP applications in previous studies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the high q2 issue in urban grids in NoahMP, posted here in this thread:
https://forum.mmm.ucar.edu/threads/high-urban-moisture-with-noah-mp-in-mpas-atmosphere-8-2-3.22160/#post-53574
Essentially, the fix is to correct the q2 diagnostics in NoahMP in hotfix-v8.3.1:
in the Noah-MP source file: EnergyVarOutTransferMod.F90
Line 139: MPAS-Model/src/core_atmosphere/physics/physics_noahmp/drivers/mpas/EnergyVarOutTransferMod.F90 at ac3866c1e5b05f6d4f5bd41aeab7d3882bace514 · MPAS-Dev/MPAS-Model
change it to the following:
NoahmpIO%Q2MXY(I) = NoahmpIO%Q2MBXY(I) * ( 1 - NoahmpIO%FVEGXY(I) ) + NoahmpIO%Q2MVXY(I) * NoahmpIO%FVEGXY(I)
I have done a short test with the hotfix-8.3.1 version and with this q2_diag fix, and show this fix will help reduce the high q2 over urban points. please see the figure below:
@cenlinhe @barlage