Skip to content

refactor: unify alias between activities_to_create and activities#228

Merged
paulboosz merged 8 commits intomainfrom
refactor/unify-alias
Mar 9, 2026
Merged

refactor: unify alias between activities_to_create and activities#228
paulboosz merged 8 commits intomainfrom
refactor/unify-alias

Conversation

@paulboosz
Copy link
Collaborator

@paulboosz paulboosz commented Feb 26, 2026

🔧 Problem

MTES-MCT/ecobalyse#1860

🏝️ How to test

just delete-database Ecobalyse && just create-activities && just sync-datapackages && just export-food

-> no diff

ecobalyse PR : MTES-MCT/ecobalyse#1882

@paulboosz paulboosz marked this pull request as ready for review February 27, 2026 12:01
@paulboosz paulboosz requested a review from ccomb February 27, 2026 12:01
Copy link
Collaborator

@ccomb ccomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand the new file meat_to_animal.json. Where is it used?

Why can't we put the live animal in activities.json?

@paulboosz
Copy link
Collaborator Author

Not sure to understand the new file meat_to_animal.json. Where is it used?

Oyes I shouln't have commited this, its a WIP.
Should be ok now

@paulboosz paulboosz requested review from ccomb and cedricr March 2, 2026 08:16
Copy link
Collaborator

@cedricr cedricr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processes.json and ingredients.json are modified by the PR and should be included

@paulboosz
Copy link
Collaborator Author

paulboosz commented Mar 5, 2026

processes.json and ingredients.json are modified by the PR and should be included

indeed it's done.

ecobalyse PR : MTES-MCT/ecobalyse#1882

paulboosz added a commit to MTES-MCT/ecobalyse that referenced this pull request Mar 9, 2026
@paulboosz paulboosz merged commit 1bace57 into main Mar 9, 2026
7 of 8 checks passed
@paulboosz paulboosz deleted the refactor/unify-alias branch March 9, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants