Skip to content

♻️ Correction du type History #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

benjlevesque
Copy link
Member

No description provided.

TPayload = Record<string, unknown>,
> = {
TEvent extends DomainEvent = DomainEvent,
> = TEvent & {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est ca le fix :)

Comment on lines +5 to +6
| Lauréat.GarantiesFinancières.GarantiesFinancièresEnregistréesEvent
| Lauréat.GarantiesFinancières.AttestationGarantiesFinancièresEnregistréeEvent,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai un doute sur celui là @JulienPavon @HubM , c'est normal ?

@benjlevesque benjlevesque force-pushed the refactor/history-type branch from 6e573fb to bf25756 Compare July 8, 2025 14:14
Copy link
Collaborator

@VioMrqs VioMrqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En vrai ça me va, y'a 2/3 moments où on supprime les matchs mais je crois que c'est ok car ton typage est plus restrictif. J'ai fait des remarques pour le naming des props au début mais je crois qu'on s'en fiche un peu, c'est jsute histoire d'être cohérent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants