feat: add configuration for task-bar text color#128
Open
WillCDev wants to merge 1 commit intoMaTeMaTuK:mainfrom
Open
feat: add configuration for task-bar text color#128WillCDev wants to merge 1 commit intoMaTeMaTuK:mainfrom
WillCDev wants to merge 1 commit intoMaTeMaTuK:mainfrom
Conversation
adam-tkaczyk-mck
approved these changes
Nov 2, 2022
|
Hi guys, but it can't be done through style? |
Author
|
@AquilesOliveiraDev Can you elaborate your question sorry? I don't follow. |
|
@WillCDev, i'm sorry. Now I understand the need for the feature. I have been using the fill attribute on the text element to do the color adjustment. |
|
Hello for the textColor when it will deploy to the plugin? We really need this config. |
ullibniss
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an additional optional configuration item called
textColorto the Task styles to allow local overrides of of the task bar text color. This is important for accessibility to maintain contrast between BG color and text color when you have passed a light colour for the task bar background. It's also just quite useful in general.Also cleaned up the task-bar-module style definitions and removed unnecessary repetition.