Fixed #3600

[felixlotter]

The problem was that after loading NCAlgebra, putting a list next to a ring creates a non-commutative polynomial ring. Adding "new Array from" fixed the problem.

[d-torrance]

Does this also fix #3601? It would probably also be good to add a test that shows that the bug is fixed.

[felixlotter]

Does this also fix #3601?

The problem in #3601 is independent of NCAlgebra, so unfortunately this is not fixed.

EDIT: I found the problem and solved it by using a dictionary. But I don't know if this is the best/standard way to do this?
EDIT: Unfortunately, the fix created new problems. I reverted the commits for now.

[d-torrance]

@mikestillman - Does this change look okay to you?

[mahrud]

I think there's something wrong with the indentation here, which makes it look like you edited every line here. Could you revise this commit? (I can show you tomorrow if you don't know how to do this)

[d-torrance]

The StatePolytope tests are failing now:

i1 : R = QQ[a,b];

i2 : I = ideal(a^2+b^2,a*b);

o2 : Ideal of R

i3 : initialIdeals(I)  
currentString:1:2:(3):[9]: error: no method for binary operator * applied to objects:
            x1 (of class Symbol)
      *     x2 (of class Symbol)

This method calls gfan from gfanInterface:

o3 = -- code for method: initialIdeals(Ideal)
     /usr/share/Macaulay2/StatePolytope.m2:35:24-35:51: --source code:
     initialIdeals(Ideal) := (I) -> apply(gfan I, first)

[d-torrance]

The new test is failing:

 -- -- -*- M2-comint -*- hash: 741132826
 -- 
 -- i1 : 
 --      	R = QQ[a];
 -- 
 -- i2 : 	gfanConvertToNewRing(R);
 -- stdio:3:28:(3): error: no method for adjacent objects:
 --             gfanConvertToNewRing (of class Symbol)
 --     SPACE   R (of class PolynomialRing)
 -- 
stdio:1:5:(3): error: test(s) #2 of package gfanInterface failed.

Either gfanConvertToNewRing could be exported or it could be loaded in the test:

importFrom(gfanInterface, "gfanConvertToNewRing")

[mikestillman]

This looks good to me. Thanks!