Skip to content

added package ExteriorExtensions #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

LukeOeding
Copy link

Adding package under review at JSAG.
I've corrected some spelling errors.

Adding package under review at JSAG.
fixed spelling errors
Copy link
Author

@LukeOeding LukeOeding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed spelling errors

@d-torrance d-torrance changed the base branch from master to development April 23, 2025 22:33
Copy link
Member

@d-torrance d-torrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Don't forget to add the package to the file M2/Macaulay2/packages/=distributed-packages.

added ExteriorExtensions
@d-torrance
Copy link
Member

There are some conflicts in the =distributed-packages file with some other packages that have been added recently. If you click on the "Resolve conflicts" button, you should see something like:

<<<<<<< master
ExteriorExtensions
=======
IncidenceCorrespondenceCohomology
ToricHigherDirectImages
Brackets
>>>>>>> development

Delete the <<<'s, ==='s, and >>>'s and then commit to fix the conflicts.

See also https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github for more info.

@d-torrance
Copy link
Member

You should add a few tests (using the TEST keyword) to make sure that your code is doing the correct thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants