Skip to content

Update SpectralSequences.m2 #3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Conversation

n-m-g
Copy link
Contributor

@n-m-g n-m-g commented May 13, 2025

A few additional "legacy" ChainComplex items removed.

A few additional "legacy" ChainComplex items removed.
@n-m-g
Copy link
Contributor Author

n-m-g commented May 13, 2025

Not sure why some checks fail. Here is the install on my machine:


i3 : restart
Macaulay2, version 1.24.11
with packages: ConwayPolynomials, Elimination, IntegralClosure, InverseSystems, Isomorphism, LLLBases, MinimalPrimes, OnlineLookup,
PackageCitations, Polyhedra, PrimaryDecomposition, ReesAlgebra, Saturation, TangentCone, Truncations, Varieties

i1 : uninstallPackage"SpectralSequences"

i2 : installPackage("SpectralSequences", RemakeAllDocumentation => true)
-- making example results for "spectralSequencePage(FilteredComplex,ZZ)" -- 1.17391s elapsed
-- making example results for "Filtrations and homomorphism complexes" -- 1.39002s elapsed
-- making example results for "filteredComplex(Ideal,Complex,ZZ)" -- 3.18693s elapsed
-- making example results for "Spectral sequences and hypercohomology calculations" -- 1.20053s elapsed
-- making example results for "minimalPresentation(SpectralSequencePage)" -- 1.243s elapsed
-- making example results for "FilteredComplex ^ ZZ" -- .621685s elapsed
-- making example results for "pruningMaps(SpectralSequencePage)" -- 1.34802s elapsed
-- making example results for "Edge homomorphisms" -- .677941s elapsed
-- making example results for "Balancing Tor" -- 1.86746s elapsed
-- making example results for "Computing the Serre Spectral Sequence associated to a Hopf Fibration" -- .985726s elapsed
-- making example results for "filteredComplex(SpectralSequence)" -- .626131s elapsed
-- making example results for "I-adic filtrations of chain complexes and their spectral sequences" -- 1.04532s elapsed
-- making example results for "SpectralSequence ^ ZZ" -- 1.0914s elapsed
-- making example results for "pruningMaps" -- 1.34664s elapsed
-- making example results for "Seeing Cancellations" -- 4.35607s elapsed
-- making example results for "Spectral sequences and non-Koszul syzygies" -- 1.25393s elapsed
-- making example results for "chainComplex(FilteredComplex)" -- .621401s elapsed
-- making example results for "Complex ** FilteredComplex" -- .680757s elapsed
-- making example results for "chainComplex(SpectralSequence)" -- .617652s elapsed
-- making example results for "PageMap" -- 1.34452s elapsed
-- making example results for "Hom(FilteredComplex,Complex)" -- .792664s elapsed
-- making example results for "Page" -- .753538s elapsed
-- making example results for "hilbertPolynomial(SpectralSequencePage)" -- .992971s elapsed
-- making example results for "edgeComplex" -- .675543s elapsed
-- making example results for "SpectralSequencePageMap ^ List" -- .881627s elapsed
-- making example results for "Examples of change of rings Spectral Sequences" -- 12.1055s elapsed
-- making example results for "inducedMap(FilteredComplex,ZZ)" -- .711255s elapsed
-- making example results for "Spectral sequences and connecting morphisms" -- .849077s elapsed
-- making example results for "spectralSequence" -- .920251s elapsed
-- making example results for "A spectral sequence which fails to degenerate quickly" -- 1.64808s elapsed
-- making example results for "filtered complexes and spectral sequences from simplicial complexes" -- 1.05387s elapsed
-- making example results for "filteredComplex(Complex)" -- .618952s elapsed
-- making example results for "tensor(RingMap,Complex)" -- .61249s elapsed
-- making example results for "homologyIsomorphism(SpectralSequence,ZZ,ZZ,ZZ)" -- 1.21379s elapsed
-- making example results for "Filtrations and tensor product complexes" -- 1.50873s elapsed
-- making example results for "The fibration of the Klein Bottle over the sphere with fibers the sphere" -- .776531s elapsed
-- making example results for "netPage" -- 2.2424s elapsed
-- making example results for "SpectralSequencePage ^ List" -- .654276s elapsed
-- making example results for "basis(List,SpectralSequencePage)" -- 1.04871s elapsed
-- making example results for "support(Complex)" -- .614349s elapsed
-- making example results for "spectralSequence(FilteredComplex)" -- .619019s elapsed
-- making example results for "minimalPresentation(SpectralSequence)" -- 1.23357s elapsed
-- making example results for "SpectralSequencePageMap _ List" -- .885096s elapsed
-- making example results for "Example 1" -- .71814s elapsed
-- making example results for "filteredComplex(List)" -- .672833s elapsed
-- making example results for "Example 2" -- .756808s elapsed
-- making example results for "Example 3" -- .689549s elapsed
-- making example results for "SpectralSequencePage _ List" -- .644848s elapsed
-- making example results for "Identifying anti-podal points of the two sphere" -- .747859s elapsed
-- making example results for "How to make filtered complexes from chain complex maps" -- .637763s elapsed
-- making example results for "spectralSequencePage" -- .884333s elapsed
-- making example results for "The trivial fibration over the sphere with fibers the sphere" -- .696257s elapsed
-- making example results for "Filtered complexes and simplicial complexes" -- .908882s elapsed
-- making example results for "SpectralSequence _ ZZ" -- 1.09325s elapsed

o2 = SpectralSequences

o2 : Package

i3 : check "SpectralSequences";
-- capturing check(0, "SpectralSequences") -- .061648s elapsed
-- capturing check(1, "SpectralSequences") -- .330103s elapsed
-- capturing check(2, "SpectralSequences") -- 4.55816s elapsed
-- capturing check(3, "SpectralSequences") -- .692785s elapsed
-- capturing check(4, "SpectralSequences") -- 3.45285s elapsed
-- capturing check(5, "SpectralSequences") -- 10.2316s elapsed


@d-torrance
Copy link
Member

Which SpectralSequences pull request is the correct one? This one or #3805? Please pick one and close the other.


chainComplex FilteredComplex := ChainComplex => K -> K_infinity
chainComplex FilteredComplex := Complex => K -> K_infinity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the build error is coming from this line. This should probably be complex instead of chainComplex. (Since very recently, chainComplex isn't defined as a method function in Core any more.)

@n-m-g
Copy link
Contributor Author

n-m-g commented May 13, 2025 via email

A few of the remaining "chainComplex" items are simply commented out as they aren't needed strictly speaking.  Let's see if this builds OK (fingers crossed!).  All of the examples and checks work on my machine.
@n-m-g
Copy link
Contributor Author

n-m-g commented May 14, 2025

Hi,

To confirm this version installs and works fine on my machine (but apparently still does not build). It should be free of "chainComplex" conflicts now as well. Do let me know what the "build issues" still may be.

Best,
Nathan

Try to build again.
@mahrud
Copy link
Member

mahrud commented May 14, 2025

  1. Click on one of the failed builds
  2. Click on Details
  3. Click on Summary (top left)
  4. Scroll down to Artifacts and download one of the build logs
  5. Extract the archive and open the error files to see what is failing.

@d-torrance
Copy link
Member

The builds are failing because several of the examples are too big and the GitHub runners are running out of memory. This example shows up several times:

i1 : B = QQ[a..d];

i2 : J = ideal vars B;

o2 : Ideal of B

i3 : C = complex complete res monomialCurveIdeal(B,{1,3,4});

i4 : K = filteredComplex(J,C,4);
Insufficient memory for the allocation

Also this one:

i1 : S = ZZ/101[x,y];

i2 : I = ideal(x^2,x*y,y^2);

o2 : Ideal of S

i3 : R = S/I;

i4 : kR = coker vars R;

i5 : kS = coker vars S;

i6 : CS = complex res kS;

i7 : CR = complex res(kR,LengthLimit=>6);

i8 : CS' = CS**R;

i9 : E = prune spectralSequence (CS' ** filteredComplex CR);
Insufficient memory for the allocation

I tried these on my system and they both hang.

@n-m-g
Copy link
Contributor Author

n-m-g commented May 14, 2025

This is strange. Memory issues may be possible. The install and run is OK on my machine at present. However, this has happened before (hanging on install) but then the issue seemed to resolve itself. They installed OK on other machines and then after a restart, uninstall etc., then everything seemed to work OK.

Here is what I see when I installed the file.

i2 : restart
Macaulay2, version 1.24.11
with packages: ConwayPolynomials, Elimination, IntegralClosure, InverseSystems,
Isomorphism, LLLBases, MinimalPrimes, OnlineLookup,
PackageCitations, Polyhedra, PrimaryDecomposition, ReesAlgebra,
Saturation, TangentCone, Truncations, Varieties

i1 : uninstallPackage"SpectralSequences"

i2 : installPackage"SpectralSequences"
-- making example results for "spectralSequencePage(FilteredComplex,ZZ)" -- 1.1896s elapsed
-- making example results for "Filtrations and homomorphism complexes" -- 1.41151s elapsed
-- making example results for "filteredComplex(Ideal,Complex,ZZ)" -- 3.22263s elapsed
-- making example results for "Spectral sequences and hypercohomology calculations" -- 1.20343s elapsed
-- making example results for "minimalPresentation(SpectralSequencePage)" -- 1.23906s elapsed
-- making example results for "FilteredComplex ^ ZZ" -- .622144s elapsed
-- making example results for "pruningMaps(SpectralSequencePage)" -- 1.35283s elapsed
-- making example results for "Edge homomorphisms" -- .681427s elapsed
-- making example results for "Balancing Tor" -- 2.08504s elapsed
-- making example results for "Computing the Serre Spectral Sequence associated to a Hopf Fibration" -- 1.02678s elapsed
-- making example results for "filteredComplex(SpectralSequence)" -- .63747s elapsed
-- making example results for "I-adic filtrations of chain complexes and their spectral sequences" -- 1.05215s elapsed
-- making example results for "SpectralSequence ^ ZZ" -- 1.11351s elapsed
-- making example results for "pruningMaps" -- 1.38373s elapsed
-- making example results for "Seeing Cancellations" -- 4.44132s elapsed
-- making example results for "Spectral sequences and non-Koszul syzygies" -- 1.31594s elapsed
-- making example results for "Complex ** FilteredComplex" -- .694569s elapsed
-- making example results for "PageMap" -- 1.38481s elapsed
-- making example results for "Hom(FilteredComplex,Complex)" -- .810394s elapsed
-- making example results for "Page" -- .766684s elapsed
-- making example results for "hilbertPolynomial(SpectralSequencePage)" -- 1.00222s elapsed
-- making example results for "edgeComplex" -- .679642s elapsed
-- making example results for "SpectralSequencePageMap ^ List" -- .888919s elapsed
-- making example results for "Examples of change of rings Spectral Sequences" -- 12.226s elapsed
-- making example results for "inducedMap(FilteredComplex,ZZ)" -- .709192s elapsed
-- making example results for "Spectral sequences and connecting morphisms" -- .86592s elapsed
-- making example results for "spectralSequence" -- .931276s elapsed
-- making example results for "A spectral sequence which fails to degenerate quickly" -- 1.66218s elapsed
-- making example results for "filtered complexes and spectral sequences from simplicial complexes" -- 1.07329s elapsed
-- making example results for "filteredComplex(Complex)" -- .646499s elapsed
-- making example results for "tensor(RingMap,Complex)" -- .630053s elapsed
-- making example results for "homologyIsomorphism(SpectralSequence,ZZ,ZZ,ZZ)" -- 1.23999s elapsed
-- making example results for "Filtrations and tensor product complexes" -- 1.52826s elapsed
-- making example results for "The fibration of the Klein Bottle over the sphere with fibers the sphere" -- .811596s elapsed
-- making example results for "netPage" -- 2.27979s elapsed
-- making example results for "SpectralSequencePage ^ List" -- .665238s elapsed
-- making example results for "basis(List,SpectralSequencePage)" -- 1.10963s elapsed
-- making example results for "support(Complex)" -- .636308s elapsed
-- making example results for "spectralSequence(FilteredComplex)" -- .639043s elapsed
-- making example results for "minimalPresentation(SpectralSequence)" -- 1.2698s elapsed
-- making example results for "SpectralSequencePageMap _ List" -- .949958s elapsed
-- making example results for "Example 1" -- .762266s elapsed
-- making example results for "filteredComplex(List)" -- .693077s elapsed
-- making example results for "Example 2" -- .7933s elapsed
-- making example results for "Example 3" -- .707579s elapsed
-- making example results for "SpectralSequencePage _ List" -- .66424s elapsed
-- making example results for "Identifying anti-podal points of the two sphere" -- .757582s elapsed
-- making example results for "How to make filtered complexes from chain complex maps" -- .660025s elapsed
-- making example results for "spectralSequencePage" -- .939767s elapsed
-- making example results for "The trivial fibration over the sphere with fibers the sphere" -- .718784s elapsed
-- making example results for "Filtered complexes and simplicial complexes" -- .924228s elapsed
-- making example results for "SpectralSequence _ ZZ" -- 1.14704s elapsed

o2 = SpectralSequences

o2 : Package

Best,
Nathan

@n-m-g
Copy link
Contributor Author

n-m-g commented May 17, 2025

Can we try this build again? Do let me know.

@n-m-g n-m-g closed this May 17, 2025
@n-m-g n-m-g reopened this May 17, 2025
@n-m-g
Copy link
Contributor Author

n-m-g commented May 17, 2025

Actually, the install hangs on my machine now as well (trying to install on Macaulay2, version 1.25.05).

Some examples still fail --- presumably for the same memory related issues.  Most examples seem to run OK but the install takes a very long time for some reason.
@n-m-g
Copy link
Contributor Author

n-m-g commented May 17, 2025

I guess we should start to compare this file a bit with the one that Mike was able to get working. I haven't done that yet.

@n-m-g
Copy link
Contributor Author

n-m-g commented May 17, 2025

I just checked the "old" version of the package again that installs with the "legacy code". It is still using the internal to the package methods and not the "new" methods in "Complexes". So, it is important to understand which examples (and why) take to long to run in the current set-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants