-
Notifications
You must be signed in to change notification settings - Fork 253
Update SpectralSequences.m2 #3807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
A few additional "legacy" ChainComplex items removed.
Not sure why some checks fail. Here is the install on my machine:i3 : restart i1 : uninstallPackage"SpectralSequences" i2 : installPackage("SpectralSequences", RemakeAllDocumentation => true) o2 = SpectralSequences o2 : Package i3 : check "SpectralSequences";
|
Which SpectralSequences pull request is the correct one? This one or #3805? Please pick one and close the other. |
|
||
chainComplex FilteredComplex := ChainComplex => K -> K_infinity | ||
chainComplex FilteredComplex := Complex => K -> K_infinity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the build error is coming from this line. This should probably be complex
instead of chainComplex
. (Since very recently, chainComplex
isn't defined as a method function in Core any more.)
To clarify, we were overloading chainComplex (for filtered complexes and spectral sequences) so maybe now we need to change chainComplex to complex everywhere (even for our filtered complex methods etc.). I can do that.
… On May 13, 2025, at 7:41 AM, Doug Torrance ***@***.***> wrote:
@d-torrance requested changes on this pull request.
In M2/Macaulay2/packages/SpectralSequences.m2 <#3807 (comment)>:
>
-chainComplex FilteredComplex := ChainComplex => K -> K_infinity
+chainComplex FilteredComplex := Complex => K -> K_infinity
I believe the build error is coming from this line. This should probably be complex instead of chainComplex. (Since very recently, chainComplex isn't defined as a method function in Core any more.)
—
Reply to this email directly, view it on GitHub <#3807 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABC62JBDSB6265VOZZM4KL326HK7FAVCNFSM6AAAAAB47WFOWKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMZWGQYDSNZWGE>.
You are receiving this because you authored the thread.
|
A few of the remaining "chainComplex" items are simply commented out as they aren't needed strictly speaking. Let's see if this builds OK (fingers crossed!). All of the examples and checks work on my machine.
Hi, To confirm this version installs and works fine on my machine (but apparently still does not build). It should be free of "chainComplex" conflicts now as well. Do let me know what the "build issues" still may be. Best, |
Try to build again.
|
The builds are failing because several of the examples are too big and the GitHub runners are running out of memory. This example shows up several times: i1 : B = QQ[a..d];
i2 : J = ideal vars B;
o2 : Ideal of B
i3 : C = complex complete res monomialCurveIdeal(B,{1,3,4});
i4 : K = filteredComplex(J,C,4);
Insufficient memory for the allocation Also this one: i1 : S = ZZ/101[x,y];
i2 : I = ideal(x^2,x*y,y^2);
o2 : Ideal of S
i3 : R = S/I;
i4 : kR = coker vars R;
i5 : kS = coker vars S;
i6 : CS = complex res kS;
i7 : CR = complex res(kR,LengthLimit=>6);
i8 : CS' = CS**R;
i9 : E = prune spectralSequence (CS' ** filteredComplex CR);
Insufficient memory for the allocation I tried these on my system and they both hang. |
This is strange. Memory issues may be possible. The install and run is OK on my machine at present. However, this has happened before (hanging on install) but then the issue seemed to resolve itself. They installed OK on other machines and then after a restart, uninstall etc., then everything seemed to work OK. Here is what I see when I installed the file. i2 : restart i1 : uninstallPackage"SpectralSequences" i2 : installPackage"SpectralSequences" o2 = SpectralSequences o2 : Package Best, |
Can we try this build again? Do let me know. |
Actually, the install hangs on my machine now as well (trying to install on Macaulay2, version 1.25.05). |
Some examples still fail --- presumably for the same memory related issues. Most examples seem to run OK but the install takes a very long time for some reason.
I guess we should start to compare this file a bit with the one that Mike was able to get working. I haven't done that yet. |
I just checked the "old" version of the package again that installs with the "legacy code". It is still using the internal to the package methods and not the "new" methods in "Complexes". So, it is important to understand which examples (and why) take to long to run in the current set-up. |
A few additional "legacy" ChainComplex items removed.