SRdeformations 0.53: use Polyhedra instead of OldPolyhedra #3814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minimal changes to SRdeformations to make it compatible with Polyhedra instead of OldPolyhedra. There aren't any tests, but I checked and the examples in the documentation basically haven't changed (in a couple of places some answers were permuted, but I believe it's the same).
@jankoboehm does this look okay to you?
Note that the package still overrides a few symbols from Polyhedra and at least a few from other packages, so further improvements can be made, but for the purposes of deprecating
OldPolyhedra
this seems to suffice.Here are the changes in the documentation which I believe are permutations of the correct answer:
In the documentation of Complex:
In the documentation of hull