Skip to content

SRdeformations 0.53: use Polyhedra instead of OldPolyhedra #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

mahrud
Copy link
Member

@mahrud mahrud commented May 14, 2025

This PR makes minimal changes to SRdeformations to make it compatible with Polyhedra instead of OldPolyhedra. There aren't any tests, but I checked and the examples in the documentation basically haven't changed (in a couple of places some answers were permuted, but I believe it's the same).

@jankoboehm does this look okay to you?

Note that the package still overrides a few symbols from Polyhedra and at least a few from other packages, so further improvements can be made, but for the purposes of deprecating OldPolyhedra this seems to suffice.

Here are the changes in the documentation which I believe are permutations of the correct answer:

In the documentation of Complex:

i8 : complement C

 o8 = 2: x x x  x x x  x x x  x x x  x x x  x x x  x x x  x x x
-         3 4 5  1 4 5  2 1 5  2 3 4  3 0 4  1 0 4  2 3 1  2 1 0
+         4 5 3  1 4 5  1 5 2  4 2 3  0 4 3  1 0 4  1 2 3  1 0 2

In the documentation of hull

i6 : dC.grading

-o6 = | 0 1 -1 -1 0  |
+o6 = | 0 1 -1 1  0  |
      | 0 1 1  -1 0  |
-     | 0 1 -1 1  0  |
+     | 0 1 -1 -1 0  |
+     | 0 1 -1 -1 2  |
+     | 1 0 0  0  1  |
      | 1 0 0  0  -1 |
      | 1 0 2  0  -1 |
      | 1 0 0  2  -1 |
-     | 1 0 0  0  1  |
-     | 0 1 -1 -1 2  |

@jankoboehm
Copy link
Contributor

Looks good to me. Thx a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants