-
Notifications
You must be signed in to change notification settings - Fork 253
Remove various grammar files #3825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
The highlight.js grammar file is now generated using the new generateGrammar function from the Style package in its own repository: https://github.com/d-torrance/highlightjs-macaulay2
Since when did highlight.js move to its own repository? |
I started it a few years ago, but still kept the template file here in the main repo for make-M2-symbols.m2 to do its thing. |
I just pushed a commit removing the textmate grammar files. This is now in the vscode-macaulay2 repository (see Macaulay2/vscode-macaulay2#2). |
Atom itself reached EOL in 2022 when Microsoft bought GitHub. The grammar is still used by Linguist (GitHub's syntax highlighter), and this has been moved to the language-macaulay2 repository. [ci skip]
I pushed another commit, this time removing the Atom files. Atom itself hasn't been maintained in a few years (when Microsoft bought GitHub, efforts were switched over to VS Code). It's still used by Linguist so GitHub can syntax highlight Macaulay2 code, but updating the grammar is now handled at https://github.com/Macaulay2/language-macaulay2 |
Could you add a readme file in the editors directory with links and descriptions of all subdirectories of editors as well as links to external repositories related to it? e.g. something similar to the readme file in the docker directory. |
[ci skip]
Good idea! Done |
Each subdirectory contains one or more template files for a particular | ||
application. | ||
|
||
* [`Macaulay2Web`](Macaulay2Web): Symbols for the Macaulay2 web app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this one? The file is basically empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the Macaulay2Web repository should have this, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's for autocompletion -- it's just a list of all the the symbols.
Cc: @pzinn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added in #3463. Now that generateGrammar
is exported, let's also remove this one. It doesn't need to be generated only during the build.
The highlight.js grammar file is now generated using the new generateGrammar function from the Style package in its own repository: https://github.com/d-torrance/highlightjs-macaulay2