Skip to content

Remove various grammar files #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

d-torrance
Copy link
Member

The highlight.js grammar file is now generated using the new generateGrammar function from the Style package in its own repository: https://github.com/d-torrance/highlightjs-macaulay2

The highlight.js grammar file is now generated using the new
generateGrammar function from the Style package in its own repository:
https://github.com/d-torrance/highlightjs-macaulay2
@d-torrance d-torrance requested a review from mahrud May 17, 2025 18:16
@mahrud
Copy link
Member

mahrud commented May 17, 2025

Since when did highlight.js move to its own repository?

@d-torrance
Copy link
Member Author

I started it a few years ago, but still kept the template file here in the main repo for make-M2-symbols.m2 to do its thing.

@d-torrance
Copy link
Member Author

I just pushed a commit removing the textmate grammar files. This is now in the vscode-macaulay2 repository (see Macaulay2/vscode-macaulay2#2).

@d-torrance d-torrance changed the title Remove highlight.js files Remove various grammar files May 26, 2025
Atom itself reached EOL in 2022 when Microsoft bought GitHub.  The
grammar is still used by Linguist (GitHub's syntax highlighter), and
this has been moved to the language-macaulay2 repository.

[ci skip]
@d-torrance
Copy link
Member Author

I pushed another commit, this time removing the Atom files. Atom itself hasn't been maintained in a few years (when Microsoft bought GitHub, efforts were switched over to VS Code). It's still used by Linguist so GitHub can syntax highlight Macaulay2 code, but updating the grammar is now handled at https://github.com/Macaulay2/language-macaulay2

@mahrud
Copy link
Member

mahrud commented May 26, 2025

Could you add a readme file in the editors directory with links and descriptions of all subdirectories of editors as well as links to external repositories related to it? e.g. something similar to the readme file in the docker directory.

@d-torrance
Copy link
Member Author

Good idea! Done

Each subdirectory contains one or more template files for a particular
application.

* [`Macaulay2Web`](Macaulay2Web): Symbols for the Macaulay2 web app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this one? The file is basically empty.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the Macaulay2Web repository should have this, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's for autocompletion -- it's just a list of all the the symbols.

Cc: @pzinn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in #3463. Now that generateGrammar is exported, let's also remove this one. It doesn't need to be generated only during the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants