reapply 6d1cd4a09 and 32a7f2ee069cc28 from LieTypes #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e3bd6ae16df3ca89ebc6a93e from LieTypes
dswinarski
merged commit 31b429b
into
Macaulay2:LieAlgebraRepresentations
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One should check that the reintroduction of
isIsomorphicis compatible with the recent changes to theIsomorphismpackage. The logic is sound -- isomorphism and equality remain the same forLieAlgebraModule, which makes sense ifLieAlgebraModuleis secretly an isomophism class of representations (this might need to be stated in the documentation somewhere).