Skip to content

Norm replaced with custom-norm for julia v1.12 #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Norm replaced with custom-norm for julia v1.12 #453

wants to merge 4 commits into from

Conversation

sshin23
Copy link
Member

@sshin23 sshin23 commented Jul 13, 2025

Due to JuliaGPU/CUDA.jl#2811, we temporarily replace norm() with mynorm(), where map is used instead

amontoison
amontoison requested changes Jul 13, 2025
View reviewed changes
Copy link
Member

@amontoison amontoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mynorm should call directly CUBLAS.nrm2 on GPU.
Please add a dispatch in MadNLPGPU.jl.

@sshin23 sshin23 requested a review from amontoison July 14, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontoison amontoison Awaiting requested review from amontoison

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshin23 @amontoison