fix: Update Valkey image source in docker-compose#2060
Draft
asterixix wants to merge 1 commit intoMail-0:stagingfrom
Draft
fix: Update Valkey image source in docker-compose#2060asterixix wants to merge 1 commit intoMail-0:stagingfrom
asterixix wants to merge 1 commit intoMail-0:stagingfrom
Conversation
Starting in 2025, docker.io/bitnami/ tags were removed or migrated, so bitnami/valkey:8.0 simply no longer exists at that address. Using the official Valkey image.
There was a problem hiding this comment.
Pull request overview
Updates local database docker-compose configuration to use the official Valkey image instead of the Bitnami image (which is no longer available at the referenced tag/registry path).
Changes:
- Switch
valkeyservice image fromdocker.io/bitnami/valkey:8.0tovalkey/valkey:8.0.
Comments suppressed due to low confidence (1)
docker-compose.db.yaml:22
- Switching from Bitnami to the official
valkey/valkeyimage likely makesALLOW_EMPTY_PASSWORDandVALKEY_DISABLE_COMMANDSineffective (those env vars are Bitnami-specific). If you still need these behaviors, configure them via Valkey/Redis config (e.g.,requirepass/ ACLs andrename-command/disabled commands) or adjust the container command to pass the appropriate flags.
image: valkey/valkey:8.0
environment:
- ALLOW_EMPTY_PASSWORD=yes
- VALKEY_DISABLE_COMMANDS=FLUSHDB,FLUSHALL
ports:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
19
| image: valkey/valkey:8.0 | ||
| environment: |
There was a problem hiding this comment.
After switching to valkey/valkey, the current volume target path under /bitnami/valkey/data is very likely no longer the correct data directory, which can break persistence (data written elsewhere in the container won’t be stored in the named volume). Update the mount to the official image’s data dir (commonly /data) or whatever path the image documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starting in 2025, docker.io/bitnami/ tags were removed or migrated, so bitnami/valkey:8.0 simply no longer exists at that address. Using the official Valkey image.
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Security Considerations
For changes involving data or authentication:
Checklist
Additional Notes
Add any other context about the pull request here.
Screenshots/Recordings
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.