-
Notifications
You must be signed in to change notification settings - Fork 140
Rename SMTPS to Submissions and deprecate old variable #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Well, its ready for merge, so it would be appreciated not to close it. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Unstale once more |
@fastlorenzo i dont mind helping out with maintenance of these charts. Let me know how i can help. |
I think before this get's merged and released, a hint could be inserted that, if the old variable is used, the chart fails to render, spitting an explanatory error, that tells about the deprecation. This breaking change would e.g. break my mailu deployment if I would upgrade. Here's an example what traefik did, when they made a breaking change to theirs values schema: Their previous syntax was:
This was changed to the following:
When the old Syntax is used today, the Chart fails to render and yields an explanatory error |
Fixes #364