Skip to content

Rename SMTPS to Submissions and deprecate old variable #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WebSpider
Copy link
Contributor

Fixes #364

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 11, 2024
@WebSpider
Copy link
Contributor Author

Well, its ready for merge, so it would be appreciated not to close it.

@github-actions github-actions bot removed the Stale label Oct 12, 2024
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 11, 2024
@WebSpider
Copy link
Contributor Author

Unstale once more

@WebSpider
Copy link
Contributor Author

@fastlorenzo i dont mind helping out with maintenance of these charts. Let me know how i can help.

@github-actions github-actions bot removed the Stale label Nov 14, 2024
@aki-ks
Copy link
Contributor

aki-ks commented Mar 24, 2025

I think before this get's merged and released, a hint could be inserted that, if the old variable is used, the chart fails to render, spitting an explanatory error, that tells about the deprecation. This breaking change would e.g. break my mailu deployment if I would upgrade.


Here's an example what traefik did, when they made a breaking change to theirs values schema:
https://github.com/traefik/traefik-helm-chart/blob/39a4a3d66b28b11b8bec0f0dc2fb53712b9716df/traefik/templates/_podtemplate.tpl#L605-L607

Their previous syntax was:

ports:
  web:
    redirectTo: websecure

This was changed to the following:

ports:
  web:
     redirections:
        entryPoint:
          to: websecure
          scheme: https
          permanent: true

When the old Syntax is used today, the Chart fails to render and yields an explanatory error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename smtps to submissions
2 participants