Avoid overwriting authorization header #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The
copySessionJwtToBearerHeader
utility request handler blindly overwrites any existingAuthorization
header value with aBearer {}
value, if there is an auth session.This is confusing behaviour when you explicitly set an
Authorization
header value on a request and it is overwritten from a session cookie.It seems a better approach would be:
Authorization
header value, set it (from the session cookie).Authorization
header values when needed, for specific requests.