Skip to content

Conversation

@iliuta
Copy link

@iliuta iliuta commented Nov 16, 2025

Hi @Malte2036 ,

Can I submit a PR for updating the dependencies of your nice library?

Thank you. Tell me what you think.

Also I added the MacOS runner for the example app. I needed this because otherwise I could not start it locally.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project's dependencies to their latest versions and adds macOS support to the example application, enabling local development on macOS platforms.

Key Changes:

  • Updated core dependencies (flutter_blue_plus to 2.0.2, permission_handler to 12.0.1, flutter_lints to 6.0.0, etc.)
  • Added macOS platform configuration and required files for the example app
  • Updated code to accommodate API changes in flutter_blue_plus v2.x (new license parameter, parameter reordering)
  • Added platform-specific permission handling for macOS

Reviewed Changes

Copilot reviewed 29 out of 39 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pubspec.yaml Updated dependency versions to latest stable releases
lib/src/bluetooth.dart Added macOS permission handling and flutter_blue_plus v2 API compatibility
test/ftms_bluetooth_test.mocks.dart Regenerated mocks for updated mockito and flutter_blue_plus versions
example/pubspec.yaml Updated example app dependencies
example/macos/* Added complete macOS platform support files and configurations
example/lib/main.dart Added error handling with user feedback for command operations
example/test/widget_test.dart Added placeholder widget test file
Files not reviewed (1)
  • example/macos/Runner.xcworkspace/contents.xcworkspacedata: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malte2036
Copy link
Owner

Hey @iliuta,

thanks for your PR.

The linter fails, because of your dependency upgrades.

Run flutter analyze
Analyzing flutter_ftms...                                       

warning • This default clause is covered by the previous cases • example/lib/main.dart:120:7 • unreachable_switch_default
   info • Don't use 'BuildContext's across async gaps • example/lib/main.dart:127:28 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps • example/lib/main.dart:131:28 • use_build_context_synchronously
   info • Library names are not necessary • lib/flutter_ftms.dart:1:9 • unnecessary_library_name
   info • Missing type annotation • lib/src/bluetooth.dart:8:10 • strict_top_level_inference
   info • Missing type annotation • lib/src/bluetooth.dart:37:10 • strict_top_level_inference
   info • Missing type annotation • lib/src/bluetooth.dart:53:10 • strict_top_level_inference
   info • Missing type annotation • lib/src/bluetooth.dart:60:10 • strict_top_level_inference
   info • Missing type annotation • lib/src/ftms/characteristic/data/device_data.dart:68:3 • strict_top_level_inference
   info • Missing type annotation • lib/src/utils.dart:26:35 • strict_top_level_inference
   info • Missing type annotation • lib/src/utils.dart:37:26 • strict_top_level_inference


11 issues found. (ran in 10.4s)

Could you take a look at it. Afterwards I can merge your PR 😄.

@iliuta
Copy link
Author

iliuta commented Nov 16, 2025

Hi @Malte2036 , yes, I've just saw. I'll check for it.

@iliuta
Copy link
Author

iliuta commented Nov 16, 2025

can you check again, please? thanks

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 31 out of 41 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • example/macos/Runner.xcworkspace/contents.xcworkspacedata: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malte2036 Malte2036 merged commit 9f37493 into Malte2036:main Nov 16, 2025
7 checks passed
@Malte2036
Copy link
Owner

Published with flutter_ftms: ^1.2.0 😁

@iliuta
Copy link
Author

iliuta commented Nov 16, 2025

Nice, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants