Fix treadmill data issues. Tested on real machine. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical data parsing bug in the Treadmill device implementation where missing energy-related parameters caused incorrect parsing of subsequent fields like heart rate and elapsed time when connected to real treadmill hardware.
Key Changes:
- Added missing
energyPerHour(2 bytes) andenergyPerMinute(1 byte) parameters whenexpendedEnergyFlagis set - Renamed
expendedEnergytototalEnergyto align with the naming convention used in other device types (IndoorBike, Rower, CrossTrainer) - Fixed the FTMS Treadmill Data characteristic structure to match the Bluetooth specification
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks for your PR. It's released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I connected to a treadmill machine, the heart rate is very high and elapsed time is not changing. Then I find treadmill data missing energy per hour and energy per minute, so heart rate and elapsed time is not correctly parsed.