Fix input_vars fetching from job options in Job #104
Conversation
putmanoj
changed the title
putmanoj
force-pushed
the
fix-input_vars-in-job
branch
from
196a1b2 to
7aea7db
Compare
putmanoj
force-pushed
the
fix-input_vars-in-job
branch
from
3870a9a to
2167c7c
Compare
| :credentials => [], | ||
| :credentials => anything, # Authentication.where(credentials), |
There was a problem hiding this comment.
I think we should try to match the expected credentials here not anything and comment this out
There was a problem hiding this comment.
Interesting this actually passes with the old [] still was there a reason you changed this?
There was a problem hiding this comment.
reverting back to []
It started failing for spy function - https://github.com/putmanoj/manageiq-providers-embedded_terraform/blob/fix-input_vars-in-job/spec/models/manageiq/providers/embedded_terraform/automation_manager/job_spec.rb#L106
in between working on the issue ..., in logs could see credential as ActiveRecord relation, ....
also being credential is empty list .. putting anything seems to fix it the problem then,
| @@ -178,7 +178,7 @@ def input_vars_type_constraints | |||
| end | |||
|
|
|||
| def input_vars | |||
| options.fetch(:input_vars, {}) | |||
There was a problem hiding this comment.
Why was this not working previously? Was the issue that the input_vars passed in above had another nested input_vars ? Maybe if you have an example of the previous payload
There was a problem hiding this comment.
Okay I see the payload in the issue
:input_vars=>{
"execution_ttl"=>"",
"verbosity"=>"0",
"input_vars"=>{
"name"=>"World"
}
},
There was a problem hiding this comment.
Yes, after changes for 'extra_vars' removal , .., as these test were using simulated values ..., tests gave a false positive result
|
Checked commits putmanoj/manageiq-providers-embedded_terraform@72f7f7b~...18ea6f8 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint |
|
Backported to |
Fix input_vars fetching from job options in Job (cherry picked from commit 08c48c2)
Fix the fetching of
:input_varsfrom job options,Fixes #103