Skip to content

Drop VCR secrets since we don't use VCR in this repo #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jul 1, 2025

@Fryguy
Copy link
Member Author

Fryguy commented Jul 1, 2025

@agrare Do we even use secrets here? Should I just drop these secrets?

@agrare agrare self-assigned this Jul 1, 2025
@agrare agrare added the enhancement New feature or request label Jul 1, 2025
@agrare
Copy link
Member

agrare commented Jul 1, 2025

@Fryguy we don't use VCR or Secrets so yeah we can just drop them completely

@Fryguy
Copy link
Member Author

Fryguy commented Jul 1, 2025

Ok let me change this PR then

@Fryguy Fryguy changed the title Switch to use VcrSecrets helper from core Drop VCR secrets since we don't use VCR in this repo Jul 1, 2025
@miq-bot
Copy link
Member

miq-bot commented Jul 1, 2025

Checked commit Fryguy@9fbbd96 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare merged commit 96521b0 into ManageIQ:master Jul 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants