Expose ServiceTerraformTemplate#execute without wait #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
May 8, 2025
| # this is essentially launch_terraform_template_queue | ||
| # | ||
| # @returns [Numeric] task_id (passed into wait_for_taskid) | ||
| def execute_no_wait(action) |
There was a problem hiding this comment.
In automate we use refresh_sync and I know we don't want to rename this execute_sync since it is used in a bunch of places but what about execute_async ?
|
Just a dumb naming question otherwise can't wait to get rid of the synchronous execute ❤️ |
Moving the wait_on_task into workflows - don't want to block this here
|
update:
|
agrare
reviewed
May 9, 2025
Comment on lines
+338
to
+345
| s.add_resource!(stack1, :name => ResourceAction::PROVISION) | ||
| case action | ||
| when ResourceAction::RECONFIGURE | ||
| s.add_resource!(stack2, :name => ResourceAction::RECONFIGURE) | ||
| when ResourceAction::RETIREMENT | ||
| s.add_resource!(stack2, :name => ResourceAction::RECONFIGURE) | ||
| s.add_resource!(stack3, :name => ResourceAction::RETIREMENT) | ||
| end |
There was a problem hiding this comment.
Do we need these stacks to be added as resources for anything that is being tested here?
agrare
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the wait_on_task into workflows - don't want to block this here
This has been split into an async and a blocking version.