deprecate attribute no longer uses virtual attribute #23321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtual_attribute marked the attribute for discovery we have modified discovery to include aliases so it is no longer necessary
kbrock
force-pushed
the
deprecation_aliases
branch
from
b3a41bd to
4b05909
Compare
|
Kicking now that the other PRs were merged |
|
@miq-bot cross-repo-tests /all |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Feb 11, 2025
From Pull Request: ManageIQ/manageiq#23321
1 task
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Feb 17, 2025
Fixes deprecation of this variety: Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually. This also handles aliases on association methods We use runtime method delegation instead of class load time alias_method. In Rails 7.1, the attribute/association methods aren't defined at class load time so we can't alias them. Note, we can remove virtual_column/attribute on actual attributes with alias_attribute due to: ManageIQ#23324 ManageIQ/manageiq-automation_engine#565 ManageIQ/manageiq-api#1278 ManageIQ#23321
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Feb 17, 2025
Fixes deprecation of this variety: Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually. This also handles aliases on association methods We use runtime method delegation instead of class load time alias_method. In Rails 7.1, the attribute/association methods aren't defined at class load time so we can't alias them. Note, we can remove virtual_column/attribute on actual attributes with alias_attribute due to: ManageIQ#23324 ManageIQ/manageiq-automation_engine#565 ManageIQ/manageiq-api#1278 ManageIQ#23321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtual_attribute marked the attribute for discovery we have modified discovery to include aliases so it is no longer necessary
Depends upon:
Can be merged without those, but need them to ensure the attributes are still exposed in automate and the api