Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curve_judgment_threshold in velocity scale factor estimator #337

Closed
wants to merge 6 commits into from

Conversation

rsasaki0109
Copy link
Member

@rsasaki0109 rsasaki0109 commented Aug 29, 2024

  • The current estimation of the velocity scale factor is not ideal as it also uses Doppler velocity during turns. Therefore, the estimation should use only the Doppler velocity when traveling below the curve_judgment_threshold [rad/sec].

  • Even with the above adjustment, the instantaneous velocity scale factor can still sometimes produce abnormal values like 0.3 or 1.8. These values are clearly incorrect for a velocity scale factor and should be excluded as outliers.

  • It seems that a curve judgment threshold of 0.02 rad/sec works well.

memo

  • Introducing a new parameter may cause errors in existing YAML configurations, so be cautious. There are pros and cons to adding default parameters as well.

@rsasaki0109
Copy link
Member Author

rsasaki0109 commented Aug 29, 2024

expriment
When the curve judgment threshold is 0.02 rad/sec

[velocity_scale_factor-3] [WARN] [1724929342.842129193] [velocity_scale_factor]: imu.angular_velocity.z: 0.001543
[velocity_scale_factor-3] [WARN] [1724929342.842187301] [velocity_scale_factor]: doppler_velocity: 0.014614
[velocity_scale_factor-3] [WARN] [1724929342.842194997] [velocity_scale_factor]: velocity: 0.130556
[velocity_scale_factor-3] [WARN] [1724929342.842199571] [velocity_scale_factor]: tmp_scale_factor: 0.111937
[velocity_scale_factor-3] [WARN] [1724929343.042700764] [velocity_scale_factor]: imu.angular_velocity.z: -0.000978
[velocity_scale_factor-3] [WARN] [1724929343.042894673] [velocity_scale_factor]: doppler_velocity: 0.009332
[velocity_scale_factor-3] [WARN] [1724929343.042929107] [velocity_scale_factor]: velocity: 0.072222
[velocity_scale_factor-3] [WARN] [1724929343.043032141] [velocity_scale_factor]: tmp_scale_factor: 0.129215
[velocity_scale_factor-3] [WARN] [1724929343.223617501] [velocity_scale_factor]: imu.angular_velocity.z: 0.000163
[velocity_scale_factor-3] [WARN] [1724929343.223710787] [velocity_scale_factor]: doppler_velocity: 0.022414
[velocity_scale_factor-3] [WARN] [1724929343.223736072] [velocity_scale_factor]: velocity: 0.016667
[velocity_scale_factor-3] [WARN] [1724929343.223754062] [velocity_scale_factor]: tmp_scale_factor: 1.344817
[velocity_scale_factor-3] [WARN] [1724929459.448917481] [velocity_scale_factor]: imu.angular_velocity.z: 0.001667
[velocity_scale_factor-3] [WARN] [1724929459.449003739] [velocity_scale_factor]: doppler_velocity: 1.943646
[velocity_scale_factor-3] [WARN] [1724929459.449033339] [velocity_scale_factor]: velocity: 1.997222
[velocity_scale_factor-3] [WARN] [1724929459.449055430] [velocity_scale_factor]: tmp_scale_factor: 0.973174

@rsasaki0109 rsasaki0109 reopened this Aug 29, 2024
@rsasaki0109
Copy link
Member Author

As this PR is not effective for the intended scene, I will close it for now.

@rsasaki0109 rsasaki0109 deleted the fix/autoware/velocity_scale_factor branch August 30, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant