Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eagleye_coordinate): fix misc-throw-by-value-catch-by-reference #338

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

kobayu858
Copy link
Contributor

This is a fix based on clang-tidy misc-throw-by-value-catch-by-reference error.

/home/emb4/autoware/autoware/src/universe/external/eagleye/eagleye_core/coordinate/src/convertheight.cpp:51:10: error: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference,-warnings-as-errors]
  catch (const GeographicLib::GeographicErr err)
         ^
/home/emb4/autoware/autoware/src/universe/external/eagleye/eagleye_core/coordinate/src/convertheight.cpp:67:10: error: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference,-warnings-as-errors]
  catch (const GeographicLib::GeographicErr err)
         ^

I have already confirmed that the build passes with autoware's colcon build.

@kobayu858
Copy link
Contributor Author

@rsasaki0109
Please excuse my comment as I did not have permission to set up a reviewer.
This is a minor fix baed on clang-tidy.
Please assign another reviewer if there is someone suitable for it, thank you.

@rsasaki0109 rsasaki0109 self-requested a review November 8, 2024 09:54
@rsasaki0109
Copy link
Member

Thank you for the PR. The changes look good, so I'll merge it.

@rsasaki0109 rsasaki0109 merged commit dc67f82 into MapIV:main-ros1 Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants