Adds ability to wrap geometry subtypes with span and a elements + a element functionality within coordinates #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add annotated testing links - run root index.html to view
prushforth
added a commit
to prushforth/MapML.js
that referenced
this pull request
Apr 16, 2021
…lement functionality within coordinates (Maps4HTML#383) * Adds ability to wrap geometry subtypes with spans and a * Ability to wrap geometry subtypes in links and spans * Link update * Templated tile fix * Add support for links within coordinates * Adds link tests * Removes handlers, might be needed in the future * Remove redundant self case * Fix JSHints * Add annotated testing links - run root index.html to view * Fix popup + add type attribute to map-a * Adds group link behavior * Fix grouping, and update test * Fix single feature behavior * Resolve conflict * Remove unneeded changes * Adds text/html link tests Co-authored-by: Peter Rushforth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Functionality:
<span>(&<div>) around geometry subtypes (polygon, linestring, point, etc.), adding classes using appropriate precedence<a>around geometry subtypes and have click functionality<a>within<coordinates><a>target rules set in issue Links (and spans) in <geometry> content #367Closes #367