Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
role="application"
on the map element.Close #274, Close #423, Close #466.
Ideally
role="region"
on the Leaflet container would simply have been replaced byrole="application"
, however doing so results in not being announced by NVDA.I've tested numerous combinations, e.g. moving both
aria-label
androle
to the map element, or only settingrole
on the map element andaria-label
and/oraria-roledescription
on the Leaflet container, and vice-versa, etc. This approach seems to be the most consistent one.