fixing 3 bugs & giving extra info for scoring #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunnyBingoMe
commented
Nov 4, 2019
SunnyBingoMe
commented
- granularity decision was only 1-unit, e.g. 1min, 1h, 1..., but not for 5min etc. and causing missing of non-matching items
- pd.drop_duplicate was dropping values instead of index
- the first TS item was missing due to _process_long_term_data using wrong range/index
- now providing residuals etc. for scoring
* granularity decision was only 1-unit, e.g. 1min, 1h, 1..., but not for 5min etc. and causing missing of non-matching items * pd.drop_duplicate was dropping values instead of index * the first TS item was missing due to _process_long_term_data using wrong range/index * now providing residuals etc. for scoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.