Added Plot Function + Small Fixes #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code has been changed from algorithm perspective
Plot code is added as v01 with minimal options. We return the matplotlib plot in the results['plot']
Readme has been improved a bit.
Certain errors like gaps in datetime would cause assertions due to middle samples not being sufficient from num_obs, some errors on the data types (like int64 throwing error), were fixed.
Test cases were improved for compatibility (assertEquals -> assertEqual) etc.
I am now using this code for my daily office work without problems. I am open to test with other datasets if needed too.
Also, most of the assert are not out as Codacy does not like them (they may be compiled out of the code)