Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-35850 make HOSTNAME a cmake configure variable #3765

Open
wants to merge 1 commit into
base: 11.4
Choose a base branch
from

Conversation

grooverdan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-35850

Description

As seen with openwrt and some other distros, the
determination of hostname can sometime need alternate commands.

This provides a cmake option HOSTNAME for non-windows machines for the mariadb-install-db and mariadbd-safe scripts and the support-files init scripts..

Release Notes

For packagers, HOSTNAME is now a configure option that can be set to the command used to determine the hostname at runtime.

How can this PR be tested?

cmake -DHOSTNAME="cat /proc/sys/kernel/hostname" and examine scripts/mysql_install_db.sh generated.

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.
  • This is a new compile feature for the benefit of packages that is exceptionally low risk.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

As seen with openwrt and some other distros, the
determination of hostname can sometime need alternate
commmands.

This provides a cmake option HOSTNAME for non-windows machines
for the mariadb-install-db and mariadbd-safe scripts
and the support-files init scripts..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants