MDEV-35850 make HOSTNAME a cmake configure variable#3765
Merged
grooverdan merged 2 commits intoMariaDB:11.4from May 1, 2025
Merged
MDEV-35850 make HOSTNAME a cmake configure variable#3765grooverdan merged 2 commits intoMariaDB:11.4from
grooverdan merged 2 commits intoMariaDB:11.4from
Conversation
neheb
approved these changes
Jan 15, 2025
As seen with openwrt and some other distros, the determination of hostname can sometime need alternate commmands. This provides a cmake option HOSTNAME for non-windows machines for the mariadb-install-db and mariadbd-safe scripts and the support-files init scripts..
b445bb7 to
31e842b
Compare
vuvova
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As seen with openwrt and some other distros, the
determination of hostname can sometime need alternate commands.
This provides a cmake option HOSTNAME for non-windows machines for the mariadb-install-db and mariadbd-safe scripts and the support-files init scripts..
Release Notes
For packagers, HOSTNAME is now a configure option that can be set to the command used to determine the hostname at runtime.
How can this PR be tested?
cmake -DHOSTNAME="cat /proc/sys/kernel/hostname" and examine scripts/mysql_install_db.sh generated.
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check