Skip to content
/ server Public

MDEV-35850 make HOSTNAME a cmake configure variable#3765

Merged
grooverdan merged 2 commits intoMariaDB:11.4from
grooverdan:MDEV-35850-hostname
May 1, 2025
Merged

MDEV-35850 make HOSTNAME a cmake configure variable#3765
grooverdan merged 2 commits intoMariaDB:11.4from
grooverdan:MDEV-35850-hostname

Conversation

@grooverdan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-35850

Description

As seen with openwrt and some other distros, the
determination of hostname can sometime need alternate commands.

This provides a cmake option HOSTNAME for non-windows machines for the mariadb-install-db and mariadbd-safe scripts and the support-files init scripts..

Release Notes

For packagers, HOSTNAME is now a configure option that can be set to the command used to determine the hostname at runtime.

How can this PR be tested?

cmake -DHOSTNAME="cat /proc/sys/kernel/hostname" and examine scripts/mysql_install_db.sh generated.

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.
  • This is a new compile feature for the benefit of packages that is exceptionally low risk.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@cvicentiu cvicentiu added the MariaDB Foundation Pull requests created by MariaDB Foundation label Jan 29, 2025
As seen with openwrt and some other distros, the
determination of hostname can sometime need alternate
commmands.

This provides a cmake option HOSTNAME for non-windows machines
for the mariadb-install-db and mariadbd-safe scripts
and the support-files init scripts..
@grooverdan grooverdan force-pushed the MDEV-35850-hostname branch from b445bb7 to 31e842b Compare April 10, 2025 02:37
@grooverdan grooverdan enabled auto-merge (rebase) April 30, 2025 22:47
@grooverdan grooverdan merged commit da5a4d0 into MariaDB:11.4 May 1, 2025
12 of 13 checks passed
@grooverdan grooverdan deleted the MDEV-35850-hostname branch August 13, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MariaDB Foundation Pull requests created by MariaDB Foundation

Development

Successfully merging this pull request may close these issues.

4 participants