Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-35937 InnoDB: Failing assertion: sym_node->table != NULL in pars_retrieve_table_def #3790

Open
wants to merge 1 commit into
base: 10.5
Choose a base branch
from

Conversation

Thirunarayanan
Copy link
Member

@Thirunarayanan Thirunarayanan commented Jan 27, 2025

  • The Jira issue number for this PR is: MDEV-35937

Description

  • InnoDB tries to fetch the metadata about fulltext index for discarded tablespace and fails for discarded tablespace.
    In i_s_fts_config_fill(), i_s_fts_index_cache_fill() and i_s_fts_index_table_fill(), InnoDB needs to check whether
    the tablespace is discarded or accessable before accessing the fulltext auxiliary table. This issue doesn't exist in
    10.6+ version due to MDEV-19445(commit 0aa2bc7)

How can this PR be tested?

./mtr innodb_fts.innodb_fts_misc_1

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@Thirunarayanan Thirunarayanan requested a review from dr-m January 27, 2025 07:15
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@dr-m dr-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that 0024524 had fixed this for another view. Shouldn’t also i_s_fts_index_cache_fill() and i_s_fts_index_table_fill() be fixed?

mysql-test/suite/innodb_fts/t/innodb_fts_misc_1.test Outdated Show resolved Hide resolved
Copy link
Contributor

@dr-m dr-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not seem to fully understand the failure scenario. Is this bug specific to 10.5 only? If that is the case, the commit message needs to make it clear that this fix must be null-merged to 10.6.

storage/innobase/handler/i_s.cc Outdated Show resolved Hide resolved
…_retrieve_table_def

- InnoDB tries to fetch the metadata about fulltext index for
discarded tablespace and fails for discarded tablespace.
In i_s_fts_config_fill(), i_s_fts_index_cache_fill() and
i_s_fts_index_table_fill(), InnoDB needs to check whether
the tablespace is discarded or accessable before accessing the
fulltext auxiliary table. This issue doesn't exist in
10.6+ version due to MDEV-19445(commit 0aa2bc7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants