Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Variables Refactor: Eliminate switch (opt_id) #3868

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

System Variables Refactor: Eliminate switch (opt_id) #3868

wants to merge 1 commit into from

Conversation

ParadoxV5
Copy link
Contributor

@ParadoxV5 ParadoxV5 commented Mar 5, 2025 •
edited
Loading

  • The Jira issue number for this PR is: TODO-5177

Description

Store method pointers instead of option IDs in Sys_var_rpl_filter and Sys_var_binlog_filter
Eh plans changed. I like mariadb-binlog filter objects – I wanna porting the design to mariadbd!

PR quality check

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.
  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@ParadoxV5
Sys.Var.s Refactor: Eliminate switch (opt_id)
e7b73d9 
Store method pointers instead of option IDs in
`Sys_var_rpl_filter` and `Sys_var_binlog_filter`
@ParadoxV5 ParadoxV5 requested a review from bnestere March 5, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnestere bnestere Awaiting requested review from bnestere

Assignees
No one assigned
Labels
MariaDB Corporation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ParadoxV5