-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDEV-36270 mariabackup.incremental_compressed fails in 10.11+ #3890
base: 10.5
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. Shouldn’t the target version be the earilest affected one (10.5)? We have seen this code fail in 10.4 about a year ago.
fa0a68f
to
d8e93bd
Compare
- During prepare of incremental backup, mariabackup does create new file in target directory with default file size of 4 * innodb_page_size. While applying .delta file to corresponding data file, it encounters the FSP_SIZE modification on page0 and tries to extend the file to the size which is 4 in our case. Since the table is in compressed row format, page_size for the table is 8k. This lead to shrinking of tablespace file from 65536 to 32768. This issue happens only in windows because os_file_set_size() doesn't check for the current size and shrinks the file. Solution: ======== xtrabackup_apply_delta(): Check for the current size before doing setting size for the file.
d8e93bd
to
9406095
Compare
Description
Problem:
Solution:
xtrabackup_apply_delta(): Check for the current size before doing setting size for the file.
How can this PR be tested?
./mtr mariabackup.incremental_compressed
Basing the PR against the correct MariaDB version
main
branch.PR quality check