MDEV-34621: Fix division by zero in mariadb-slap when iterations=0 #3892
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvicentiu
added
the
External Contribution
svoj
requested changes
Mar 19, 2025
KhaledR57
force-pushed
the
MDEV-34621
branch
2 times, most recently
from
8192b45 to
88a6cfd
Compare
svoj
requested changes
Mar 20, 2025
There was a problem hiding this comment.
Adjust commit comment according to https://github.com/MariaDB/server/blob/11.0/CODING_STANDARDS.md
That is split long lines. Sentences should end with period.
Could you also retarget it for 10.6? Or I can do it myself once PR is approved.
|
|
svoj
approved these changes
Mar 20, 2025
mariadb-slap crashes with a floating point exception when run with -iterations=0 due to division by zero in generate_stats(). This occurs when calculating average timing by dividing by the number of iterations. To fix this, the solution checks if iterations == 0 before performing the division, and returns early from the function in such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mariadb-slapcrashes with a floating point exception when run with-i0due to division by zero ingenerate_stats(). This occurs when calculating average timing by dividing by the number of iterations.Instead of modifying the minimum value for the
-ioption (which would cause unexpected warning messages even with valid values), this PR implements a targeted fix in thegenerate_stats(). The solution checks ifiterations == 0before performing the division, and in such cases, returns early from the function.Release Notes
Fixed a floating point exception (division by zero) crash in
mariadb-slapwhen running with-i0(zero iterations).How can this PR be tested?
This PR can be tested by manually running mariadb-slap with zero iterations, which would previously cause a crash:
Or
Basing the PR against the correct MariaDB version
mainbranch.PR quality check