MDEV-35304 fixup: Threading-agnostic MTR test #3897
+53
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the `multi_source.connects_tried` feature test:
* Replace the main course from timing checks to checking timing
* Not using a specific SLEEP eliminates the possibility (of failure)
that it awakens before the `Connects_Tried` counter increments.
* In replacement-based tests of conventional views (SHOW & variants),
assert the parallel values without distinguishing which is which
* There were rare cases where both values end up equal (even though
one was configured to tick more frequently than the other).
* Comment touchups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jira issue number for this PR is: MDEV-35304Description
Improve the
multi_source.connects_triedfeature test:Connects_Triedcounter increments.Release Notes
N/A
How can this PR be tested?
It has been evident that timing tests easily lead to sporadic failures.
Perhaps our CI (Buildbot) are overloaded with concurrent jobs that their thread schedulers had to make possibly-unrealistic compromises.
PR quality check
(Yes, this is a refactoring fix concerning a
main-exclusive (unreleased) new feature.)mainbranch.