MDEV-36810 Deduplicate LOG_EVENT_OFFSET
#4218
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LOG_EVENT_OFFSET
is a duplicate ofEVENT_TYPE_OFFSET
andBIN_LOG_HEADER_SIZE
depending on the context.(GitHub Blame shows that it came from a changeset import from before I was born 🧒.)
While there, centralize
BIN_LOG_HEADER_SIZE
tosql/rpl_constants.h
previously fromsql/unireg.h
andclient/mysqlbinlog.cc
)Release Notes
N/A
How can this PR be tested?
See that the change doesn’t cause failures on every testing builder
PR quality check
main
branch.This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.