Skip to content

MDEV-36034 thd->killed ignored by high level function leading to assertion #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 11.8
Choose a base branch
from
Open

MDEV-36034 thd->killed ignored by high level function leading to assertion #4374

wants to merge 1 commit into from
+37 −0

Conversation

mariadb-RexJohnston
Copy link
Member

@mariadb-RexJohnston
MDEV-36034 thd->killed ignored by high level function leading to asse…
e4e4347 
…rtion

if thd->killed is set for any reason at a critical point during
get_quick_record_count, JOIN::build_explain() isn't called and
Sql_cmd_update::execute_inner() doesn't return an error code to indicate
failure.
vuvova
vuvova reviewed Oct 16, 2025
View reviewed changes
sql/sql_select.cc
DBUG_RETURN(false); // Fatal error flag is set

DBUG_EXECUTE_IF ("MDEV-36034-A",
thd->set_killed_no_mutex(KILL_TIMEOUT, 0, nullptr); );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do it without DBUG_EXECUTE_IF please?
E.g. with existing DEBUG_SYNC, if possible. Those DBUG_EXECUTE_IF don't improve readability, they're a necessary evil, but still evil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vuvova vuvova vuvova left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mariadb-RexJohnston @vuvova