-
-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Creality CR-6 SE #19958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bugfix-2.1.x
Are you sure you want to change the base?
Creality CR-6 SE #19958
Conversation
10a0e23 to
818dd80
Compare
b095b3f to
866a567
Compare
|
I want to be clear, because I don't think I had been: we're still doing stability testing on this - but I'd like to get early feedback, so when we act on that feedback we catch any resulting bugs early :) |
|
(Besides, I don't want you to waste your time cleaning up any mess I made 😀 ) |
866a567 to
b1c6a99
Compare
This has been updated to the latest codebase for maximum relevance and to accelerate integration. Today I'll continue to refine this PR, first to get it compiling, and then to merge the |
ced4f08 to
4342798
Compare
|
I've some additional input on the use of the COM_PIN:
So, based on the above, the strain gauge reset needs to happen:
|
ff1ef0e to
b4814c0
Compare
ae1e325 to
fe268ae
Compare
fe268ae to
8e218b3
Compare
c6c4f85 to
76a7096
Compare
3791e7d to
6ea4a16
Compare
0436f2a to
517fec7
Compare
how goes teh merge request |
517fec7 to
5a03c9b
Compare
1f8610c to
09ed8a7
Compare
09ed8a7 to
b8aa165
Compare
b8aa165 to
4173aa9
Compare
52532da to
06c6c47
Compare
4173aa9 to
430a764
Compare
430a764 to
3edceb9
Compare
d6a2a46 to
84f4d9f
Compare
84f4d9f to
cbb2bb4
Compare
Rebase of #19955 by @Sebazz
With this pull request I'm looking for some early feedback on the Creality CR-6 SE changes. I don't expect this to be merged at all, but I hope that we can get some feedback how to improve this so it might be merged upstream some day.
Requirements
The famous Kickstarter Creality CR-6 has a firmware based on an early version of Marlin 2.0 (I traced it back to commit 25a7ceab where the fork was made). About a month ago the source code was released, and after tracing the origin I've started re-implementing the changes on top of Marlin 2.0.x-bugfix - so essentially making Marlin 2.7.1 available to the users.
The main pain point was the "spaghetti" that is the touch screen interfacing code. We have been re-implementing this on top of ExtUI, which allowed some large switch statements and opaque code, including a home-baked filament runout detection, to be cleaned up.
We've made the following extensions to the base functionality of the CR-6 SE:
Description
The Creality CR-6 SE has two distinct features that require new support in Marlin:
Auto bed leveling using the nozzle - the entire hot-end is attached to a strain gauge you can also find in your average kitchen scale. The hot-end is lowered to the bed, and using a threshold determine by a small potmeter, a signal is send that is interpreted as a Z-endstop trigger. This is done for homing and leveling the entire bed. Although the strain gauge / hot-end daughter board is powered by a 32-bit STM processor, there is no real communication between the mainboard and the daughter board. Because the strain gauge can trigger at any time, an optical sensor is used for determining when to "listen" to the strain gauge. Only when the optical sensor is triggered (which is determined by a metal piece - in hardware), then the strain gauge is activated. It is a bit of a double edged sword though, if the strain gauge is set too sensitive it will trigger too early and cause bad bed leveling or homing to fail, if the strain gauge is set with a too low sensitivity, the entire hotend is driven into the bed with force. But that is not something firmware can fix 😀
DWIN DGUS touch screen - The Creality CR-6 SE features a touch screen from DWIN, similar to the Ender 3 V2 except a somewhat more advanced model it appears. We've been developing a separate firmware for that.
The following is thanks to the Ender 3 V2 already implemented:
Configurations
For now I've included them inside the pull request.
Related Issues
None - as far as I'm aware.
Additional notes / questions
Watchdog - Creality configured a watchdog timer but it appears that the watchdog is not used (enabled) at all?
Optical switch triggering of strain gauge - I was not sure where to place this code.
G29 leveling heats the bed - Added a new configuration option
AUTOLEVEL_NEEDS_PREHEATING. The Creality implementation of the leveling preheats to at least 120 degrees C, possibly to account for metal expansion of the nozzle or hot-end. So, leveling requires a certain temperature.Extensible UI extensions
Disable/enable steppers - Allow disabling of steppers to be communicated to the touch screen
More callbacks to ExtUI regarding the leveling process - It was quite hard to get leveling reliable without explicit callbacks when leveling starts or when a point was probed. This is shown live on the display.
Callback when a print is completed
Callbacks when homing is being done
Implementation of touch screen interfacing code - The existing touch screen interfacing code that was already present for DWIN did many assumptions which don't hold true for the Creality implementation. Among others, in the Creality firmware the VP (virtual pointers) are reused across pages or even within the pages. What is a cooldown button on one page, is a "save preheat settings for PLA" on another page. The callback structure does an assumption that a single VP is a single button, in addition to what the values of those buttons are. It doesn't hold true for the Creality touch screen, nor is it easy to change/refactor that touch screen - not in the least due to the buggy DWIN editor. Also, I've encountered some weird issues with the particular piece of hardware of the CR-6 that required me to add some duct tape to the communication code. I don't like that I had to copy code, but I think that plastering more preprocessor code on top of that would not have benefit the code either.