-
-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Soft feed hold using REALTIME_REPORTING_COMMANDS (P000) or FREEZE_PIN #28265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DerAndere1
wants to merge
24
commits into
MarlinFirmware:bugfix-2.1.x
Choose a base branch
from
DerAndere1:feed_hold
base: bugfix-2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the freeze_feature to use acceleration when triggering freeze_pin
Prevents calculating unnecessary linear acceleration rate during path planning when using s_curve_acceleration. General cleanup and commented out feature by default in configuration.
User has the option of turning the laser off when motion is halted regardless of laser mode. Once motion starts previous laser power is restored. Also makes changes to feature description in config_adv.h
If freeze is triggered when machine is stationary it immediately sets solid flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects- and unifies the logic of two older pull requests: PR #27592 and PR #27976
Introduce the SOFT_FEED_HOLD option.
When enabled both, the FREEZE_PIN (FREEZE_FEATURE) as well as REALTIME_REPORTING_COMMANDS P000 and R000 acceleration and decelerate instead of starting / stopping instantaneously
Requirements
FREEZE_PIN (optional)
Benefits
Configurations
Enable
SOFT_FEED_HOLD,EMERGENCY_PARSERandREALTIME_REPORTING_COMMANDSto test commands P000 and R000.And/or enable
SOFT_FEED_HOLD,FREEZE_FEATUREandFREEZE_PINto test FREEZE_PINRelated Issues
PR #27592
PR #27976
Fix #27964