Add a feature flag to disable LCD reinit #28273
Open
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some displays (e.g. MKS Mini12864 V3) have slow, blocking initialization procedures. When going from the main menu to the info screen or when inserting an SD card, Marlin attempts to reinitialize the display to combat noise. If done mid-print, the whole printer may pause, including all motion, causing blobs. This PR adds a feature flag to disable this behavior, at the cost of having to restart the printer to restore display if noise becomes an issue.
Requirements
Benefits
Add a feature flag to disable LCD reinit during operation.
Configurations
Simply uncomment
#define REINIT_NOISY_LCD 0at line 1536 inConfiguration_adv.h.Related Issues