Added Bezier curve and showed it in UtilsDemo. #34
Conversation
|
|
||
| namespace Monofoxe.Engine.Drawing | ||
| { | ||
| public class BezierCurve |
| { | ||
| public class BezierCurve | ||
| { | ||
| public static void Draw(Vector2[] controlPoints, float interval = 0.01f) |
There was a problem hiding this comment.
Add the autodoc comment describing what the method does and what the arguments are for.
|
|
||
| for (var i = 0; i < points.Length - 1; i += 1) | ||
| { | ||
| LineShape.Draw(points[i], points[i + 1]); |
There was a problem hiding this comment.
This is inefficient, you should be pushing vertices to the vertexbatch like LineShape.Draw() does.
|
|
||
| namespace Monofoxe.Engine.Drawing | ||
| { | ||
| public class BezierCurve |
There was a problem hiding this comment.
Rename to BezierCurveShape to keep consistency with other such classes.
|
|
||
| #region Bezier curve stuff. | ||
| // A look up table for factorials. Capped to 16. | ||
| private static float[] Factorial = new float[] |
There was a problem hiding this comment.
This is a private field, the naming should be _factorial
| float uu = u * u; | ||
| int N = controlPoints.Length - 1; | ||
|
|
||
| if (N > 16) |
There was a problem hiding this comment.
Should also add a check for less than 3 points.
| /// <summary> | ||
| /// Returns an array of points spaced with passed interval. | ||
| /// </summary> | ||
| public static Vector2[] BezierCurvePoints(Vector2[] controlPoints, float interval = 0.01f) |
There was a problem hiding this comment.
Remove this method, it's not really needed.
| /// </summary> | ||
| /// <param name="value">Should be in 0..1 range.</param> | ||
| public static Vector2 BezierCurve(Vector2 startPoint, Vector2 controlPoint, Vector2 endPoint, float value) | ||
| public static Vector2 BezierCurve(Vector2[] controlPoints, float value) |
There was a problem hiding this comment.
Return three-point BezierCurve, it can exist alongside the n-point bezier.
public static Vector2 BezierCurve(float value, params Vector2[] points)
{
// ...
}
public static Vector2 BezierCurve(float value, Vector2 startPoint, Vector2 controlPoint, Vector2 endPoint)
{
// ...
}
| @@ -118,6 +118,18 @@ public UtilsDemo(Layer layer) : base(layer) | |||
| _stateMachine.AddState(TestStates.Blue, Blue); | |||
| _stateMachine.AddState(TestStates.Red, Red); | |||
| // State machine. | |||
|
|
|||
There was a problem hiding this comment.
Add three-point bezier demo and add a demo that calls GameMath.BezierCurve directly.
| @@ -56,7 +56,7 @@ public class UtilsDemo : Entity | |||
|
|
|||
| Sprite _fireSprite; | |||
|
|
|||
|
|
|||
| Vector2[] _bezierCurvePoints; | |||
There was a problem hiding this comment.
private Vector2[] _bezierCurvePoints;
No description provided.