Skip to content

Commit

Permalink
V1.3.1
Browse files Browse the repository at this point in the history
  • Loading branch information
haneefdm committed Jan 29, 2022
1 parent 3f13b59 commit d0a3537
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
ChangeLog
=========
# V1.3.1 (preview release for 1.4.0)
* Improved startup code for `launch` and `attach`. Quite a bit of old unneeded code removed following VSCode's current APIs. We were doing a few things inefficiently and thew updated VSCode APIs helped. We have a few too many options for startup like `runToEntryPoint`, `breakAfterReset`, etc. along with user defined overrides/pre/post commands. These are consolidated. This will also reduce the number of updated that happen to the various windows. We tested best we could but this is yet another major change.
* Also the reset/restart processing uses virtually the same code as startup.
* More improvements in disassembly, faster and better. Tried to make it a bit more generic to handle non-ARM architectures, but 32-bit ARM remains a priority and that is the only thing available for testing.
* Issue #585, hopefully addressed.

# V1.3.0 (preview release for 1.4.0)
* New Feature: Support for Logpoints. Log points allow you to print debug information to the Debug Console without stopping the program (but a breakpoint has to be used internally by gdb). [Setting Logpoints is similar to setting/editing breakpoints in the editor](https://code.visualstudio.com/blogs/2018/07/12/introducing-logpoints-and-auto-attach#_introducing-logpoints). The value of what you enter in the dialog box is similar to arguments to printf (but don't actually use the word printf and ***NO commas and arguments should be separated by a space***)
```sh
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.3.0",
"version": "1.3.1",
"preview": false,
"activationEvents": [
"onDebugResolve:cortex-debug",
Expand Down
6 changes: 3 additions & 3 deletions src/backend/disasm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -658,12 +658,12 @@ export class GdbDisassembler {
{
return new Promise(async (resolve, reject) => {
try {
await this.getMemoryRegions();
const seq = request?.seq;
if (GdbDisassembler.debug) {
this.handleMsg('log', `Debug-${seq}: Dequeuing...\n`);
ConsoleLog('disassembleRequest: ', args);
}
await this.getMemoryRegions();

const baseAddress = parseInt(args.memoryReference);
const offset = args.offset || 0;
Expand All @@ -675,8 +675,8 @@ export class GdbDisassembler {
}
const startAddr = Math.max(0, Math.min(baseAddress, baseAddress + (instrOffset * this.maxInstrSize)));
const endAddr = baseAddress + (args.instructionCount + instrOffset) * this.maxInstrSize;
this.handleMsg('log', 'Start: ' + ([startAddr, baseAddress, baseAddress - startAddr].map((x) => hexFormat(x))).join(',') + '\n');
this.handleMsg('log', 'End : ' + ([baseAddress, endAddr, endAddr - baseAddress].map((x) => hexFormat(x))).join(',') + '\n');
// this.handleMsg('log', 'Start: ' + ([startAddr, baseAddress, baseAddress - startAddr].map((x) => hexFormat(x))).join(',') + '\n');
// this.handleMsg('log', 'End : ' + ([baseAddress, endAddr, endAddr - baseAddress].map((x) => hexFormat(x))).join(',') + '\n');

const ranges = this.findDisasmRanges(startAddr, endAddr, baseAddress);
const promises = ranges.map((r) => this.getProtocolDisassembly(r, args));
Expand Down

0 comments on commit d0a3537

Please sign in to comment.