#343 feat(domain) Aggregation Resilience #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermasking
requested changes
Nov 4, 2024
|
|
||
| it('should give the valid posts only', async () => | ||
| { | ||
| await remove(REQUESTERS.CREATOR1, VALUES.IDS.POST_RATED); |
There was a problem hiding this comment.
This remove call modifies the test fixtures to fit the test assertions below, basically saying that the fixtures do not support this test scenario. Instead of calling the remove function, we need to update the fixtures.
petermasking
requested changes
Nov 5, 2024
| @@ -15,29 +15,45 @@ beforeEach(async () => | |||
|
|
|||
| describe('domain/notification/getallAggregated', () => | |||
| { | |||
| it('should give all posts for the requester', async () => | |||
| it('should give all posts for the requester2', async () => | |||
There was a problem hiding this comment.
As discussed before, this description should tell what scenario is tested. Getting the posts (notifications?) for requester 2 doesn't say anything. It should be clear what's wrong if this test case fails.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request:
@MaskingTechnology/comify