Skip to content

Addition of Scroll-to-Top Button #79 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2024
Merged

Addition of Scroll-to-Top Button #79 #82

merged 4 commits into from
Jul 6, 2024

Conversation

Aaryanb45
Copy link
Contributor

Screenshot 2024-07-06 at 6 44 24 PM

@MastanSayyad
Copy link
Owner

@Aaryanb45 This is back to home button

we need scroll to top button

the button should only appear when we scroll down a bit and after clicking on it should scroll to top
for example like this:

butn.mp4

Copy link
Owner

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required

Copy link

vercel bot commented Jul 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visual-sort ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 11:01pm

@Aaryanb45
Copy link
Contributor Author

I have made the changes

Screen.20Recording.202024-07-07.20at.2012.mp4

@Aaryanb45
Copy link
Contributor Author

just review itt

Copy link
Owner

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not scrolling to top it Is directly jumping (not even jumping just teleporting)

It should scroll to top, just like the reference video I have given @Aaryanb45

@Aaryanb45
Copy link
Contributor Author

hey i have made the changes please see it and now its is going smoothly to the top page

@MastanSayyad
Copy link
Owner

@Aaryanb45 Yeah Great

Copy link
Owner

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@MastanSayyad MastanSayyad merged commit 555355a into MastanSayyad:main Jul 6, 2024
1 check passed
@MastanSayyad MastanSayyad added VSoC’24 Contribution under VSoC'24 MEDIUM issue is intermediate labels Jul 6, 2024
@Aaryanb45
Copy link
Contributor Author

Aaryanb45 commented Jul 6, 2024

hey can I get some bonus points it took my whole day and for this I have worked hard

@MastanSayyad
Copy link
Owner

@Aaryanb45 The task was that hard, but as it was your first time and you have put your time and energy in it, I can give you 10 more points (more than that will get unfair for other contributors)

@MastanSayyad MastanSayyad added HARD issue is hard and removed MEDIUM issue is intermediate labels Jul 6, 2024
@Aaryanb45
Copy link
Contributor Author

Thank u so much fr it means a lot to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HARD issue is hard VSoC’24 Contribution under VSoC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants