Skip to content

fix: Get formula building again in GitHub actions #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

ParkMyCar
Copy link
Contributor

@ParkMyCar ParkMyCar commented Feb 28, 2025

This PR gets the formulae building again a few changes were needed:

  1. Remove the use of attr_rw which is no longer available (pulled from fix: attr_rw no longer available via brew's API #12)
  2. Remove all references to [email protected] which brew doctor kept complaining about
  3. Uninstall [email protected] if it's present
  4. Fix some spellcheck lints

* mostly figure out how and why brew doctor is complaining about [email protected]
* update uses of single-quotes to double-quotes to appease some linter
@ParkMyCar ParkMyCar force-pushed the testing-build-failures branch from fc24697 to a223978 Compare February 28, 2025 17:51
@ParkMyCar ParkMyCar changed the title [dnr] debugging CI failures fix: Get formula building again in GitHub actions Feb 28, 2025
@ParkMyCar ParkMyCar requested a review from martykulma February 28, 2025 17:52
@ParkMyCar ParkMyCar marked this pull request as ready for review February 28, 2025 17:52
Copy link

@martykulma martykulma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo!

@ParkMyCar ParkMyCar merged commit b4f3ec4 into main Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants