Add warning for expire_after setting in main.tf #139
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added warning about potential downtime when changing expire_after value.
jshiwamV
reviewed
Jan 12, 2026
| node_taints = local.materialize_node_taints | ||
| # WARNING: setting this to any value other than Never may cause | ||
| # downtime. Karpenter will remove nodes regardless of whether they | ||
| # pods with do-not-disrupt labels. If you set this to any duration |
Collaborator
There was a problem hiding this comment.
Suggested change
| # pods with do-not-disrupt labels. If you set this to any duration | |
| # have pods with do-not-disrupt labels. If you set this to any duration |
jshiwamV
reviewed
Jan 12, 2026
| # WARNING: setting this to any value other than Never may cause | ||
| # downtime. Karpenter will remove nodes regardless of whether they | ||
| # pods with do-not-disrupt labels. If you set this to any duration | ||
| # you should ensure that you always gracefull roll nodes during a |
Collaborator
There was a problem hiding this comment.
gracefull -> gracefully?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added warning about potential downtime when changing expire_after value.