[webhooks] Decompress request bodies #32611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkMyCar
force-pushed
the
webhook/decompress-bodies
branch
from
ac6806a to
882b691
Compare
def-
approved these changes
Jun 2, 2025
| assert!(resp.status().is_success(), "{resp:?}"); | ||
|
|
||
| // Wait a moment for the webhook to get appended. | ||
| std::thread::sleep(std::time::Duration::from_secs(5)); |
There was a problem hiding this comment.
Would be nicer to retry until we get the correct result (or even better, have this test in testdrive)
…ZIP decompression works
ParkMyCar
force-pushed
the
webhook/decompress-bodies
branch
from
882b691 to
43f9a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for compressed webhook bodies using the decompression layers in
tower_http. It also adds a test to ensure the decompression actually works.Motivation
More advance support for webhook bodies.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.