[persist] Upgrade arrow
to fix a minor source roundtripping issue
#32655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to pick up this upstream arrow fix: apache/arrow-rs#6953
Motivation
https://github.com/MaterializeInc/database-issues/issues/9318
Tips for reviewer
There were a couple minor API changes to adapt to as well, due to the upgrade, which explains most of the diff. (The largest is that
chrono
added a new method to a trait, shadowing our own method - I've adapted the code to use the upstream version instead.)I've committed the proptest failure, though note that it's still hard to reproduce even so... the bug only appears when two floats hash to the same bucket in a hash table, which is cot common. I could only repro the original bug after several hours of
cargo stress
; so while I'm pretty confident this is the fix, it's hard to prove with testing.Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.