adapter,storage: allow webhook sources on multi-replica clusters #32692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The restriction was artificial, webhooks don't actually run on clusters. Implements MaterializeInc/database-issues#9181
aljoscha
force-pushed
the
storage-webhook-sources-on-multi-replica-clusters
branch
from
c491542 to
bfb64d9
Compare
def-
approved these changes
Jun 9, 2025
def-
force-pushed
the
storage-webhook-sources-on-multi-replica-clusters
branch
from
58cdade to
70fc218
Compare
|
I have pushed the test changes directly into this PR and triggered nightly: https://buildkite.com/materialize/nightly/builds/12250 Edit: https://buildkite.com/materialize/nightly/builds/12251 (green) |
|
tyty! 🙇♂️ |
…h webhook sources
def-
force-pushed
the
storage-webhook-sources-on-multi-replica-clusters
branch
from
70fc218 to
d736a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restriction was artificial, webhooks don't actually run on clusters.
Implements https://github.com/MaterializeInc/database-issues/issues/9181
@def- Do we want more than this in terms of testing?